use typing mode postanalysis in qualif in the next solver#155093
use typing mode postanalysis in qualif in the next solver#155093jdonszelmann wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_passes/src/check_attr.rs changes to the core type system cc @lcnr Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in compiler/rustc_attr_parsing Some changes occurred to the CTFE machinery |
rustbot
added
A-attributes
jdonszelmann
force-pushed
the
qualif-tm-ns
branch
from
78bf308 to
57b8687
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
qualif-tm-ns
branch
from
57b8687 to
376e5ed
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jdonszelmann
force-pushed
the
qualif-tm-ns
branch
from
376e5ed to
d4cdd00
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| ty::TypingMode::PostAnalysis | ||
| } else { | ||
| ty::TypingMode::analysis_in_body(cx.tcx, cx.body.source.def_id().expect_local()) | ||
| }, |
There was a problem hiding this comment.
we should use cx.typing_env here and use its TypingMode. we currently specify that mode to be non_body_analysis which is very wrong™️, so this is a bigger change to use the proper TypingMode here. In the new solver we should generally use TypingMode::Borrowck until we're done with mir_borrowck at hwich point it should be PostBorrowckAnalysis
|
Closed in favor of #156141 |
rustbot
removed
the
S-waiting-on-review
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
… r=lcnr Resolve some cases of rust-lang#132279 by using the right typing mode in the next solver r? @lcnr Convert 3 FIXMEs of rust-lang#132279 to using the right typing mode when we can (`tcx.use_typing_mode_borrowck()`) Also resolves rust-lang#155093, which I closed
4 participants
r? @lcnr
PostAnalysiscauses no query cycles, and as far as I can tell (looked where it was called) PostAnalysis is correct for this callBuilds on #155047 so @rustbot blocked